INFRA-466: Create env file when only artifacts change a #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuisson
reviewed
Jun 14, 2024
|
@enyachoke could you reuse the logic from this function, instead of copying it? |
…te artfacts for dockerComposeFromArtifact project type
enyachoke
force-pushed
the
FixArtifactEnvBuild
branch
from
ec01d36 to
7362116
Compare
rbuisson
requested changes
Jun 17, 2024
| @@ -220,7 +220,7 @@ module.exports = { | |||
| return script; | |||
| }, | |||
| getArtifactsScript: function(instanceDef) { | |||
| return ""; | |||
| return this.getDeploymentScript(instanceDef); | |||
There was a problem hiding this comment.
Suggested change
| return this.getDeploymentScript(instanceDef); | |
| // `dockerComposeFromArtifact` deployment type requires to apply deployment scripts changes even upon artifact changes. | |
| return this.getDeploymentScript(instanceDef); |
There was a problem hiding this comment.
I have made the change.
rbuisson
approved these changes
Jun 17, 2024
enyachoke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes to bugs
dockerComposeFromArtifacttype not able to fetch private artifactsdockerComposeFromArtifacttype not creating a necessary env file when only artifacts change.