-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shallow clones #13
Comments
I thought about this but the problem is that it makes the logic of updating much more complicated. What if you change the branch configuration and had |
Keep this open for when you are bored and need something to do. :-D |
jgit does not support shallow clones yet (see https://git.eclipse.org/r/c/jgit/jgit/+/193329 ), so the implementation would probably need to switch to the native git client. I think it is reasonable to assume people would have
I would suggest adding an explicit parameter like 'fetchDepth: Int |
I am not particularly fond of the idea of re-inventing the wheel by implementing a wrapper on top of Git... |
Same here, however, I'm inclined For reference, here's IDEA's reasoning regarding native git vs jgit: https://youtrack.jetbrains.com/issue/IDEABKL-5595/git4idea-switch-to-java-implementation-of-Git#focus=Comments-27-270524.0-0 I believe the following issues directly impact
I've run into this issue when I tried using |
JGit added shallow clone support in version 6.3. |
6.x requires Java 11 :-( |
Is it an issue ? |
For instance, we keep https://github.com/pgjdbc/pgjdbc buildable with Java 8, so adding dependency on jgit which requires Java 11 would be problematic. Even thought pgjdbc does not use includegit-gradle-plugin, we use jgit for creating/pushing git tags for the release purposes, so I'm inclined to use regular git client instead. |
I think for the use-cases of this plugin doing shallow clones would be appropriate, so that you don't need to clone the full history for a repository just to use the latest state for building.
Optimally it would be an option, so that users can decide whether they want shallow clones or not.
The text was updated successfully, but these errors were encountered: