-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page for carriers #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that this should be split into pages. Similar to brands.
a4c097a
to
aaa48c3
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll assume that the info is correct. There are some individual issues with formatting, and pages should have a #
header at the top.
ac87c1c
to
90718be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your work
This page is probably going to need a few modifications before it can be merged.
I put in as much info as I can, however I couldn't do much as I'm from Canada (where carrier locking is illegal), and it's a lot harder to find details about carriers than it is phone manufacturers, most of my info is going off what I know from American friends, so there's a lot more carriers that could be added to this page.