fix: Fix hanging downstream tests in tap-postgres (#1977)

Investigate use of future=True
meltano · Sep 22, 2023 · fa25c46 · fa25c46
1 parent bb98db5
commit fa25c46
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -267,6 +267,9 @@ select = [
 ]
 src = ["samples", "singer_sdk", "tests"]
 target-version = "py37"
+unfixable = [
+    "ERA",  # Don't remove commented out code
+]
 
 [tool.ruff.per-file-ignores]
 "docs/conf.py" = [

diff --git a/singer_sdk/connectors/sql.py b/singer_sdk/connectors/sql.py
@@ -325,7 +325,6 @@ def create_engine(self) -> Engine:
             return sqlalchemy.create_engine(
                 self.sqlalchemy_url,
                 echo=False,
-                future=True,
                 json_serializer=self.serialize_json,
                 json_deserializer=self.deserialize_json,
             )
@@ -336,7 +335,6 @@ def create_engine(self) -> Engine:
             return sqlalchemy.create_engine(
                 self.sqlalchemy_url,
                 echo=False,
-                future=True,
             )
 
     def quote(self, name: str) -> str: