Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SIGTERM messages to shut down gracefully #129

Open
MeltyBot opened this issue May 17, 2021 · 5 comments · May be fixed by #2620
Open

Handle SIGTERM messages to shut down gracefully #129

MeltyBot opened this issue May 17, 2021 · 5 comments · May be fixed by #2620
Labels
Accepting Pull Requests evergreen extract kind/Feature New feature or request migrated from gitlab

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/130

Originally created by @aaronsteers on 2021-05-17 18:16:11

Summary

As brought up in this slack conversation, we have an opportunity to handle SIGTERM messages gracefully.

Proposed benefits

This could improve SDK-based taps' functionality when being told to shut down gracefully.

Proposal details

  • For any sorted incremental streams: we can flush the current stream and cancel syncing any other records.
  • For non-sorted streams and/or streams which do not support incremental refresh: we may choose to continue syncing until the stream sync completes (or until SIGKILL forces shutdown).
  • Avoid starting any other streams once the running streams are handled, as specified above.

Best reasons not to build

No downsides, no reason not to implement.
@MeltyBot
Copy link
Contributor Author

View 1 previous comment from the original issue on GitLab

@MeltyBot MeltyBot mentioned this issue May 29, 2022
Closed
@labelsync-manager labelsync-manager bot added the kind/Feature New feature or request label Jun 23, 2022
@stale
Copy link

stale bot commented Jul 18, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 18, 2023
@edgarrmondragon
Copy link
Collaborator

Still relevant

@stale Stale
Copy link

stale bot commented Jul 19, 2024

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Jul 19, 2024
@edgarrmondragon edgarrmondragon mentioned this issue Aug 20, 2024
Open
@edgarrmondragon edgarrmondragon moved this to To Discuss in Office Hours Aug 20, 2024
@WillDaSilva
Copy link
Member

Handling SIGTERM gracefully could allow SDK users to use AWS spot instances and similar without the complexity that comes from attempting to handle hibernation. A long-running pipeline could run whenever there is cheap compute available, gracefully pause when there is no cheap compute available, and then resume where it left off once it becomes available again.

I'm not sure the compute cost of SDK pipelines is a notable concern for anyone, but it'd be nice in any case. Helps with unexpected shutdowns in general.

@edgarrmondragon edgarrmondragon linked a pull request Aug 22, 2024 that will close this issue
Open
@edgarrmondragon edgarrmondragon moved this from To Discuss to Up Next in Office Hours Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting Pull Requests evergreen extract kind/Feature New feature or request migrated from gitlab
Projects
Office Hours
Status: Discussed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Interruption and termination signals are handled in taps and targets meltano/sdk
4 participants
@tayloramurphy @WillDaSilva @edgarrmondragon @MeltyBot