Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Allow skipping a partition by raising a specific exception - [opened] #635

Closed
MeltyBot opened this issue Mar 22, 2022 · 3 comments
Closed

Comments

@MeltyBot
Copy link
Contributor

MeltyBot commented Mar 22, 2022

Merges skip-partition-on-error -> main

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/merge_requests/258


This PR is a proposal to address https://gitlab.com/meltano/sdk/-/issues/282

The change proposed here is fully opt-in:

  • a new exception type SkipPartitionAPIError is added, which tap developers can raise to signify "this partition cannot be synced, but other partitions might, so continue with the next one".
  • unless that exception is raised, the tap's behaviour is unchanged,
  • in particular, if FatalAPIError is raised, the tap will stop immediately.

Typical use case for this exception would be a server-side error on the API part which cannot be resolved with the tap, other than by retrying at a later date. We are seeing quite a lot of these on the github API, with no clear pattern or cause. In most cases, retrying within a few seconds is enough, but sometimes it is not. In that case, the entire tap run is currently cancelled, which seems a fairly high price to pay.

Obviously happy to have feedback on this and adjust to make it as useful as possible.

Closes #282

@edgarrmondragon
Copy link
Collaborator

Bump. We should revive this (or go for #1597) based on errors found in tap-messagebird (slack).

@stale
Copy link

stale bot commented Aug 9, 2023

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

@stale stale bot added the stale label Aug 9, 2023
@edgarrmondragon
Copy link
Collaborator

Another PR has been started: #1844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants