Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(targets): Log sink name when an unhandled error occurs during setup #2108

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(targets): Log sink name when an unhandled error occurs during setup #2108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion singer_sdk/target_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,9 @@ def add_sink(

Returns:
A new sink for the stream.

Raises:
Exception: If sink setup fails.
"""
self.logger.info("Initializing '%s' target sink...", self.name)
sink_class = self.get_sink_class(stream_name=stream_name)
Expand All @@ -249,7 +252,13 @@ def add_sink(
schema=schema,
key_properties=key_properties,
)
sink.setup()

try:
sink.setup()
except Exception: # pragma: no cover
self.logger.error("Error initializing '%s' target sink", self.name)
raise

self._sinks_active[stream_name] = sink
return sink

Expand Down