From 6765ccb2e04b0e7d25b240047a51aa4f98fbfb88 Mon Sep 17 00:00:00 2001 From: Reuben Frankel Date: Thu, 12 Sep 2024 11:16:08 +0100 Subject: [PATCH 1/2] Document missing `schema-flattening` base capability --- docs/capabilities.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/capabilities.rst b/docs/capabilities.rst index de3565777..988a6e762 100644 --- a/docs/capabilities.rst +++ b/docs/capabilities.rst @@ -14,6 +14,7 @@ The following capabilities are supported by default. .. autoattribute:: PluginCapabilities.ABOUT .. autoattribute:: PluginCapabilities.BATCH .. autoattribute:: PluginCapabilities.STREAM_MAPS +.. autoattribute:: PluginCapabilities.FLATTENING ======================== Custom base capabilities From d9d00cd75d0c66179af4e0730a04f9f1208a0afb Mon Sep 17 00:00:00 2001 From: Reuben Frankel Date: Thu, 12 Sep 2024 11:17:20 +0100 Subject: [PATCH 2/2] Remove unused `record-flattening` capability --- .../target-template/{{cookiecutter.target_id}}/meltano.yml | 2 +- docs/capabilities.rst | 1 - singer_sdk/helpers/capabilities.py | 3 --- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/cookiecutter/target-template/{{cookiecutter.target_id}}/meltano.yml b/cookiecutter/target-template/{{cookiecutter.target_id}}/meltano.yml index dab8bf213..dc1a71bc5 100644 --- a/cookiecutter/target-template/{{cookiecutter.target_id}}/meltano.yml +++ b/cookiecutter/target-template/{{cookiecutter.target_id}}/meltano.yml @@ -21,7 +21,7 @@ plugins: capabilities: - about - stream-maps - - record-flattening + - schema-flattening # TODO: Declare settings and their types here: settings: diff --git a/docs/capabilities.rst b/docs/capabilities.rst index 988a6e762..b71df4c67 100644 --- a/docs/capabilities.rst +++ b/docs/capabilities.rst @@ -61,5 +61,4 @@ The following capabilities have to be implemented in the target. .. autoattribute:: TargetCapabilities.SOFT_DELETE .. autoattribute:: TargetCapabilities.HARD_DELETE .. autoattribute:: TargetCapabilities.DATATYPE_FAILSAFE -.. autoattribute:: TargetCapabilities.RECORD_FLATTENING .. autoattribute:: TargetCapabilities.TARGET_SCHEMA diff --git a/singer_sdk/helpers/capabilities.py b/singer_sdk/helpers/capabilities.py index 3445c5bc6..76d7fcffb 100644 --- a/singer_sdk/helpers/capabilities.py +++ b/singer_sdk/helpers/capabilities.py @@ -365,9 +365,6 @@ class TargetCapabilities(CapabilitiesEnum): #: Fail safe for unknown JSON Schema types. DATATYPE_FAILSAFE = "datatype-failsafe" - #: Allow denesting complex properties. - RECORD_FLATTENING = "record-flattening" - #: Allow setting the target schema. TARGET_SCHEMA = "target-schema"