Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the exposure filter by changing the curve formula #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

starzia
Copy link

@starzia starzia commented Jul 14, 2016

We use Caman.js's Exposure filter every day at GunMemorial.org and I have found that is does not behave as well as the exposure control in photo editing apps like Mac's Preview.app. Increasing the exposure does not increase the contrast, so blacks became grayish and the image looks washed-out. In other words, the Exposure filter behaves like a "brightness" control, not a typical exposure control.

In this patch, I changed the curve being used for the exposure filter and now if behaves much better for photographs. Rather than simply changing the "y-intercept" of the curve, it now changes the slope as well (which changes the contrast). The results look much better to me.

Please be aware that I do not have a NPM/CoffeeScript dev environment set up at the moment, so you should compile and test before merging. I tested the curve formula used in the patch by using the curve filter directly in JS, as seen in this commit:

https://github.com/starzia/GunMemorial/commit/8dfa1be02cedae29da772ee93facc7d385786f2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant