-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll up of changes from 3 github repos #16
Open
rambocoder
wants to merge
16
commits into
membase:master
Choose a base branch
from
rambocoder:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for teardown looked for teardown/0, but attempted to call teardown/1. This fix looks for teardown/1 as well
Attempted to call a function in cucumber_parser. Corrected this to cucuberl_parser.
Red for indicating failure Green for indicating normal
* Verified if a teardown/0 function was exported in the callback module. But it must be teardown/1
Add support for scenario_setup functions that is run at the beginning of each scenario.
Add red color to the not implemented message
Keeps scenario setup result in State
Built from https://github.com/basho/rebar head
Removed colorization Removed redundant cucumber_parser.erl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, the repo content works out of the box.
Your repo currently does not build without the patches from others.