Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if 'allowReserved' is set to true #104

Open
charjr opened this issue Apr 3, 2023 · 0 comments
Open

Throw error if 'allowReserved' is set to true #104

charjr opened this issue Apr 3, 2023 · 0 comments
Labels
Blocked by internal dependency Must be solved first by another membrane library external An issue that affects the users

Comments

@charjr
Copy link
Collaborator

charjr commented Apr 3, 2023

https://github.com/OAI/OpenAPI-Specification/blob/v3.0.4-dev/versions/3.0.4.md#fixed-fields-for-use-with-schema

When this is true, parameter values are serialized using reserved expansion, as defined by RFC6570, which allows RFC3986's reserved character set, as well as percent-encoded triples, to pass through unchanged, while still percent-encoding all other disallowed characters (including % outside of percent-encoded triples). Applications are still responsible for percent-encoding reserved characters that are not allowed in the query string ([, ], #), or have a special meaning in application/x-www-form-urlencoded (-, &, +); see Appendices C and E for details. This field only applies to parameters with an in value of query. The default value is false.

We currently do not handle this when parsing query strings, so we should throw a clear exception to mention this.

The reader will need to keep track of this keyword on parameters for this to happen.

@charjr charjr added external An issue that affects the users Blocked by internal dependency Must be solved first by another membrane library labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked by internal dependency Must be solved first by another membrane library external An issue that affects the users
Projects
None yet
Development

No branches or pull requests

1 participant