Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for Laravel 11 #28

Closed
sdorsazcp opened this issue Aug 26, 2024 · 2 comments · Fixed by #29
Closed

Missing support for Laravel 11 #28

sdorsazcp opened this issue Aug 26, 2024 · 2 comments · Fixed by #29

Comments

@sdorsazcp
Copy link

sdorsazcp commented Aug 26, 2024

Hello,

As I can see, the projects membrane-laravel and membrane are not compatible with the 11th (current) version of Laravel.

You should update dependencies to illuminate in version 11 for membrane-laravel:

    "illuminate/console": "^9.0 || ^10.0 || ^11.0",
    "illuminate/http": "^9.0 || ^10.0 || ^11.0",
    "illuminate/support": "^9.0 || ^10.0 || ^11.0",

But this is not suffisent, this require to update symfony dependencies in membrane/membrane and membrane/openapi-router:

    "symfony/console": "^6.2 || ^7.0",

But I don't know if this is accetable for those two projects. Juste wanted to notice you.

Thanks for your work

@charjr
Copy link
Collaborator

charjr commented Jan 7, 2025

I'm sorry this didn't get looked at sooner, I mistakenly thought my notifications were set to watch this repository.

It's more than acceptable and thank you for taking the time to detail what was needed to fix it!

I've made a PR #29 to solve this.

If there's anything else you notice, never hesitate to let us know 🙂

@carnage
Copy link
Contributor

carnage commented Jan 8, 2025

Fixed in #29

@carnage carnage closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants