Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for laravel 10 #11

Closed
wants to merge 4 commits into from
Closed

Add support for laravel 10 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d00c770
Merge branch 'update-php-unit' of https://github.com/membrane-php/mem…
philsturgeon Sep 26, 2023
8c9bbd9
upgrade to laravel v10 and membrane v0.3
philsturgeon Sep 26, 2023
9a417b4
Merge branch 'main' into laravel-10
charjr Sep 26, 2023
a701df6
Delete phpunit.xml
charjr Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
"require": {
"php": "^8.1.0",
"crell/api-problem": "^3.6.1",
"illuminate/http": "^9.0",
"illuminate/support": "^9.0",
"illuminate/http": "^9.0 || ^10.0",
"illuminate/support": "^9.0 || ^10.0",
"nyholm/psr7": "^1.8",
"membrane/membrane": "^0.2.0",
"membrane/membrane": "^0.3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried upgrading to latest membrane-core (0.6.2) but was getting errors, and 0.3.0 was the highest I could go with passing tests.

Time: 00:00.047, Memory: 12.00 MB

There were 2 PHPUnit errors:

1) Membrane\Laravel\ApiProblemBuilderTest::buildFromExceptionTest
The data provider specified for Membrane\Laravel\ApiProblemBuilderTest::buildFromExceptionTest is invalid
Class "Membrane\OpenAPI\Exception\CannotProcessRequest" not found

/Users/phil/src/membrane-laravel/tests/ApiProblemBuilderTest.php:98

2) Membrane\Laravel\Middleware\RequestValidationTest::catchesCannotProcessRequest
The data provider specified for Membrane\Laravel\Middleware\RequestValidationTest::catchesCannotProcessRequest is invalid
Class "Membrane\OpenAPI\Exception\CannotProcessRequest" not found

/Users/phil/src/membrane-laravel/tests/Middleware/RequestValidationTest.php:72

--

There was 1 failure:

1) Membrane\Laravel\Middleware\RequestValidationTest::registersResultInstanceInContainer
Expectation failed for method name is "instance" when invoked 1 time
Parameter 1 for invocation Illuminate\Contracts\Container\Container::instance('Membrane\Result\Result', Membrane\Result\Result Object (...)) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
         'header' => []
         'cookie' => []
         'body' => ''
+        'request' => [...]
     )
     'result' => 1
 )

/Users/phil/src/membrane-laravel/src/Middleware/RequestValidation.php:44
/Users/phil/src/membrane-laravel/tests/Middleware/RequestValidationTest.php:49

--

There was 1 risky test:

1) Membrane\Laravel\Middleware\RequestValidationTest::registersResultInstanceInContainer
This test did not perform any assertions

/Users/phil/src/membrane-laravel/tests/Middleware/RequestValidationTest.php:30

ERRORS!
Tests: 8, Assertions: 18, Errors: 2, Failures: 1, Risky: 1.

"symfony/psr-http-message-bridge": "^2.1"
},
"require-dev": {
Expand Down
13 changes: 0 additions & 13 deletions phpunit.xml
View file
Open in desktop

This file was deleted.