Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in related to browser connecting via WebRTC #57

Merged
merged 32 commits into from
Feb 3, 2025
Merged

Fix bugs in related to browser connecting via WebRTC #57

merged 32 commits into from
Feb 3, 2025

Conversation

FelonEkonom
Copy link
Member

@FelonEkonom FelonEkonom commented Jan 7, 2025 •
edited
Loading

Closes #52

Issues:

  • bug in signaling channel - awaits on Bump version to 0.23.1 membrane_webrtc_plugin#15
  • bug in codecs negotiation: Browser echo negotiates VP8 on one side of one connection and H264 on the second connection, while the negotiated codec should be the same
  • missing keyframe request in Browser echo example
  • Add test using headless Chrome
  • Allow connecting from both tabs for each side of the connection at the same time

@FelonEkonom FelonEkonom self-assigned this Jan 7, 2025
FelonEkonom and others added 27 commits January 8, 2025 11:51
@FelonEkonom
Bump deps, fix transcoder format resolver
5630e7e
@FelonEkonom
Start signaling channel for webrtc source in the boombox pipline
98a1fb7
@FelonEkonom
Update dep to webrtc plugin
463ef81
@FelonEkonom
Merge remote-tracking branch 'origin/master' into fix-bugs
29332b2
@FelonEkonom
Add playwright test wip
43b6578
@FelonEkonom
browser test
18b9f28
@FelonEkonom
Write tests with browser wip
39a639b
@FelonEkonom
Write tests with browser
7bc541b
@FelonEkonom
Browser tests wip
aefebd5
@FelonEkonom
Browser test wip
cef9c94
@FelonEkonom
Fix credo
b9ce14c
@FelonEkonom
Fix browser test
7ed0552
@FelonEkonom
Fix ci
c22a0f1
@FelonEkonom
Debug ci
a49a6a4
@FelonEkonom
Debu g ci
5bca189
@FelonEkonom
Debug CI
513ec83
@FelonEkonom
Fix CI
359ee41
@mickel8
Update nimble_parsec
34ded85
@FelonEkonom
Change dep
6bc44b8
@FelonEkonom
Set dependency of playwright to our fork
a924aed
@FelonEkonom
Set dependency to ref
76ce119
@FelonEkonom
Add new flag to the browser
9c447d0
@FelonEkonom
Exclude browser test on CI
7afd72a
@FelonEkonom
Remove unnecesary setep in test config
bd9249a
@FelonEkonom
Fix CI config
4c6a733
@FelonEkonom
Merge remote-tracking branch 'origin/master' into fix-bugs
35c53a2
@FelonEkonom
Add :flaky tag to one rtsp test
87c53e4
@FelonEkonom FelonEkonom marked this pull request as ready for review January 23, 2025 11:16
@FelonEkonom FelonEkonom marked this pull request as draft January 23, 2025 11:17
@FelonEkonom FelonEkonom marked this pull request as ready for review January 23, 2025 17:00
@FelonEkonom FelonEkonom requested a review from mat-hek January 28, 2025 09:53
mat-hek
mat-hek reviewed Jan 31, 2025
View reviewed changes
.circleci/config.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of a custom test job you can check if "CIRCLECI" env is set to "true" in test_helper.exs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it is better to have an explicit information in job name that browser tests are excluded on CI, to make situations when tests pass only on CI less magic

@mat-hek
Add WHIP support (#49)
69e4e81 
* add WHIP support

* refactor WHIP API, make CLI work

* fix whip IP

* update examples

* make WHIP <-> WebRTC connection work, refactor browser tests

* CR
@FelonEkonom FelonEkonom merged commit 5859bd1 into master Feb 3, 2025
3 checks passed
@FelonEkonom FelonEkonom deleted the fix-bugs branch February 3, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees

@FelonEkonom FelonEkonom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebRTC examples don't work on master
3 participants
@FelonEkonom @mat-hek @mickel8