Add max image size parameter #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldgiova
requested changes
Jul 27, 2023
| @@ -246,6 +246,7 @@ The following table lists the parameters for the `deployments` component and the | |||
| | `deployments.service.nodePort` | Node port for the service | `nil` | | |||
| | `deployments.env.DEPLOYMENTS_MIDDLEWARE` | Set the DEPLOYMENTS_MIDDLEWARE variable | `prod` | | |||
| | `deployments.env.DEPLOYMENTS_PRESIGN_SECRET` | Set the secret for generating signed url, must be a base64 encoded secret. | random value at start-up time | | |||
| | `deployments.env.DEPLOYMENTS_AWS_MAX_IMAGE_SIZE` | Set the max artifact image size in bytes. | `nil`, code defaults to 10GB | | |||
There was a problem hiding this comment.
Suggested change
| | `deployments.env.DEPLOYMENTS_AWS_MAX_IMAGE_SIZE` | Set the max artifact image size in bytes. | `nil`, code defaults to 10GB | | |
| | `deployments.env.DEPLOYMENTS_STORAGE_MAX_IMAGE_SIZE` | Set the max artifact image size in bytes. | `nil`, code defaults to 10GB | |
The AWS_MAX_IMAGE_SIZE env var is deprecated in favor of STORAGE_MAX_IMAGE_SIZE: https://github.com/mendersoftware/deployments/blob/master/config.yaml#L212
| @@ -87,6 +87,8 @@ spec: | |||
| value: {{ .Values.deployments.env.DEPLOYMENTS_AWS_TAG_ARTIFACT | quote }} | |||
| - name: DEPLOYMENTS_PRESIGN_SECRET | |||
| value: {{ .Values.deployments.env.DEPLOYMENTS_PRESIGN_SECRET | quote }} | |||
| - name: DEPLOYMENTS_AWS_MAX_IMAGE_SIZE | |||
There was a problem hiding this comment.
Suggested change
| - name: DEPLOYMENTS_AWS_MAX_IMAGE_SIZE | |
| - name: DEPLOYMENTS_STORAGE_MAX_IMAGE_SIZE |
| @@ -87,6 +87,8 @@ spec: | |||
| value: {{ .Values.deployments.env.DEPLOYMENTS_AWS_TAG_ARTIFACT | quote }} | |||
| - name: DEPLOYMENTS_PRESIGN_SECRET | |||
| value: {{ .Values.deployments.env.DEPLOYMENTS_PRESIGN_SECRET | quote }} | |||
| - name: DEPLOYMENTS_AWS_MAX_IMAGE_SIZE | |||
| value: {{ .Values.deployments.env.DEPLOYMENTS_AWS_MAX_IMAGE_SIZE | quote }} | |||
There was a problem hiding this comment.
Suggested change
| value: {{ .Values.deployments.env.DEPLOYMENTS_AWS_MAX_IMAGE_SIZE | quote }} | |
| value: {{ .Values.deployments.env.DEPLOYMENTS_STORAGE_MAX_IMAGE_SIZE | default 10737418240 | int | toString | quote }} |
A default values is missing. Either set it here, or in the mender/values.yaml
Hi @ksoloway-nuro , thanks for your contribution! I didn't meant to be rude, I thought it was an internal contribution ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding AWS_MAX_IMAGE_SIZE parameter to limit size of uploads. Defaults to 10GB.