Skip to content

Commit

Permalink
Merge pull request #48 from mendix/fix/rn-screens
Browse files Browse the repository at this point in the history
Downgrade rn screens
  • Loading branch information
Ahmad-Elsayed authored Nov 18, 2024
2 parents 0535f57 + f60e4fc commit 511b0ea
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 8 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"react-native-reanimated": "1.13.1",
"react-native-safe-area-context": "4.11.0",
"react-native-schedule-exact-alarm-permission": "^0.1.5",
"react-native-screens": "3.35.0",
"react-native-screens": "3.29.0",
"react-native-sound": "0.11.0",
"react-native-splash-screen": "3.2.0",
"react-native-svg": "15.7.1",
Expand Down
15 changes: 15 additions & 0 deletions patches/react-native-screens+3.29.0.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
diff --git a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt
index 5f77aa1..0a67b1f 100644
--- a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt
+++ b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt
@@ -44,7 +44,9 @@ class ScreenViewManager : ViewGroupManager<Screen>(), RNSScreenManagerInterface<
): Any? {
if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
// fabricViewStateManager should never be null in Fabric. The null check is only for Paper's empty impl.
- view.fabricViewStateManager?.setStateWrapper(stateWrapper)
+ if (stateWrapper != null) {
+ view.fabricViewStateManager?.setStateWrapper(stateWrapper)
+ }
}
return super.updateState(view, props, stateWrapper)
}

0 comments on commit 511b0ea

Please sign in to comment.