Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro Audit Findings #301

Closed
2 tasks done
baroooo opened this issue Nov 20, 2023 · 3 comments
Closed
2 tasks done

Macro Audit Findings #301

baroooo opened this issue Nov 20, 2023 · 3 comments
Assignees
@baroooo

Comments

@baroooo
Copy link
Contributor

baroooo commented Nov 20, 2023 •
edited
Loading

Description

Fix the findings from the Macro audit: https://www.notion.so/0xmacro/Mento-2-Preliminary-Audit-Report-external-private-9a2a743bddb0450b8e7914a4ccc96704
Fill the fixes doc: https://www.notion.so/0xmacro/Mento-2-Fixes-381c9db5a6ae4027b1323e79aecf2d3a

Findings:

Acceptance Criteria:

  • Findigs above are fixed
  • Fixes doc addresses commits for fixed issues and responses for unfixed ones
@bayological
Copy link
Member

Story Points: 3
See the discussion in Sprint Poker #​​26

Powered by Parabol

@chapati23
Copy link
Contributor

found another tiny comment typo: https://github.com/mento-protocol/mento-core/blob/feat/factory-contract-leftovers/contracts/governance/Emission.sol#L92

should read '// Avoiding underflow in case the scheduled amount is bigger than the total supply'

@baroooo baroooo self-assigned this Dec 6, 2023
@baroooo baroooo mentioned this issue Dec 6, 2023
Merged
baroooo added a commit that referenced this issue Dec 8, 2023
@baroooo
Fix: macro audit issues (#321)
ca53ca9 
### Description

This PR fixes some of the issues found in the [Macro
audit.](https://www.notion.so/Mento-2-Preliminary-Audit-Report-external-private-9a2a743bddb0450b8e7914a4ccc96704)

We originally planned to fix the following issues but we are only fixing
Q-2, Q-5 and Q-7 in this PR. Reasons are listed below:

[L-1]: Will be fixed by [another
PR](https://github.com/mento-protocol/mento-core/tree/feat/factory-contract-leftovers)
[L-2]: Will be fixed by [another
PR](https://github.com/mento-protocol/mento-core/tree/feat/factory-contract-leftovers)
[Q-2]: ✅ 
[Q-3]: ILocking is not shared between LockingBase and Airgrab as they
stated in the prelim report. Fixing this would require us to introduce a
shared interface and I am not sure if it worths such thing
[Q-4]: Will be fixed by [another
PR](https://github.com/mento-protocol/mento-core/tree/feat/factory-contract-leftovers)
[Q-5]: ✅ 
[Q-7]: ✅ 

As an addition to reviewing fixes, please go through the issues we
decided not to fix and comment below if you disaggree.

### Other changes

Typo that is found by @chapati23 is fixed

### Tested

No breaking changes.

### Related issues

- Fixes #301
@baroooo baroooo closed this as completed Dec 8, 2023
@baroooo baroooo reopened this Dec 12, 2023
@baroooo
Copy link
Contributor Author

baroooo commented Dec 18, 2023

This waits for #318 to be merged

@baroooo baroooo closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baroooo baroooo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chapati23 @bayological @baroooo