Request: add check that '.res.' is already present in restart file name to fms2_io #1
Assignees
Comments
|
@wrongkindofdoctor I pushed this commit. Please pull in the changes and let me know if it solves this issue. |
menzel-gfdl
pushed a commit
that referenced
this issue
Feb 5, 2020
Fixes to allow tests to passed on Travis CI
menzel-gfdl
pushed a commit
that referenced
this issue
Apr 23, 2020
* Correct syntax error in test_common.sh.in This commit removes the line in test_common.sh.in that had a syntax error. This removal was done to allow test_common.sh.in to support more MPI run wrappers than the openMPI wrapper. * Correct additional syntax error in test_common.sh.in I introduced another syntax error. This corrects that. * Remove html requiement from diag_integral Makefile This is needed to allow the zhi_nest_merge to pass the Travis CI tests
menzel-gfdl
pushed a commit
that referenced
this issue
Apr 23, 2020
menzel-gfdl
pushed a commit
that referenced
this issue
May 31, 2023
* Expands test matrix in travis CI * Update .travis.yml Co-authored-by: Rahul Mahajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@menzel-gfdl
MOM6 already includes the .res. in the base restart file name. Since fms2_io::open_file routine calls a routine that automatically appends .res. to the file name when is_restart = .true., this means that MOM_restart has to incorporate several additional restart name string checks and additional variables to hold two versions of the restart file name: one with .res. and one without it.
It would be simpler if:
a) fms2_io::open_file requires the user to specify .res. in restart file names, or
b) fms2_io::restart_file_path_mangle subroutine also checks for whether .res. is already present in the file name passed to the routine if is_restart = .true., and only appends .res. if it is not.
The text was updated successfully, but these errors were encountered: