Make wrapito agnostic of testing framework #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to change the matcher to use .toUpperCase for the method, to keep consistency with regular wrapito |
My two cents on this matter is that it shouldn't matter if you use |
|
Makes sense to me, just changed the types and made the matcher use uppercase to verify methods like it was in wrapito |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Make wrapito agnostic of testing framework, i.e it will work with
jest,vitestand other test frameworks if needed.🤔 Why?
wrapito-vitest🧪 How has this been tested? / 💥 How will I know if this breaks?
All tests must pass
closes #54
Migration steps
1.- Uninstall wrapito and install wrapito-vitests (changing all imports from wrapito to wrapito-vitest)
2.- Change all post/get/patch methods to uppercase
3.- Change in "src/setupTests.js" assertions with matchers
Initial tests in ACMOFy
First iteration
Expect API compatible
ACMOFy
BeeGs
Curation (vitest)
Curation (jest)