Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it only for benz? #342

Open
CCXia1997 opened this issue Sep 15, 2024 · 8 comments
Open

Is it only for benz? #342

CCXia1997 opened this issue Sep 15, 2024 · 8 comments

Comments

@CCXia1997
Copy link

It seems error when use pdx of volkswagen.

@kayoub5
Copy link
Collaborator

kayoub5 commented Sep 15, 2024

what's the error you are getting?

@andlaus
Copy link
Collaborator

andlaus commented Sep 15, 2024

odxtools is most definitely not only for Mercedes cars. That said, I obviously do not have access to diagnostics files made by/for other manufacturers and as @kayoub5 said, we're thus reliant on bug reports/patches from our users. In this case, it is likely that the issue can be fixed if you provided a traceback. also, there is a chance that your files will load if you enable the non-strict mode (in this case your mileage will vary, though).

@Ch4rg3r
Copy link

Ch4rg3r commented Sep 17, 2024

Is it possible that the specification is different? It seems that odxtools is based on version 2.2 and 2.0.1 for example is not fully supported?

@CCXia1997
Copy link
Author

CCXia1997 commented Sep 17, 2024

what's the error you are getting? @kayoub5
Version is 2.0.1 and error when use odxtools.load_odx_d_file() to resolve PROTOCOL file:
KeyError: "ODXLINK reference OdxLinkRef('ES_XXX') could not be resolved for any of the document fragments [OdxDocFragment(doc_name='ES_XXX', doc_type='LAYER')]"
ES_XXX is ECU-SHARED-DATA file and PROTOCOL file fragment is:
<IMPORT-REFS> <IMPORT-REF DOCREF="ES_XXX" DOCTYPE="LAYER" ID-REF="ES_XXX" /> </IMPORT-REFS>

@andlaus
Copy link
Collaborator

andlaus commented Sep 19, 2024

Is it possible that the specification is different? It seems that odxtools is based on version 2.2 and 2.0.1 for example is not fully supported?

yes, that's possible: we target odx 2.2, and odx 2.0 is only supported on a "best effort" basis, i.e., we happily accept patches provided that they do not break support for odx 2.2, but I personally do not have any datasets which use this version, so your mileage may vary.

KeyError: "ODXLINK reference OdxLinkRef('ES_XXX') could not be resolved [...]

that does not look like it is related to the ODX version, though. it might be a bug in odxtools (IMPORT-REFs are largely untested), or your datasset might be broken. to test whether the latter is the case, unzip the PDX file (unzip MY_FILE.pdx), grep for ID="ES_XXX" and check whether the short name of that diagnostic layer matches the DOCREF attribute of the IMPORT-REF.

@andlaus
Copy link
Collaborator

andlaus commented Oct 30, 2024

@CCXia1997: can this issue be closed? If not, it would be great if you provided more information...

@marcodadamo
Copy link

marcodadamo commented Nov 3, 2024

explanation is clear

@andlaus
Copy link
Collaborator

andlaus commented Nov 5, 2024

if you do not provide a (redacted if necessary) traceback or a file exhibiting the issue, we do not stand much of a chance of fixing this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants