-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphiql cannot be used with helmet on fresh browsers #771
Comments
I would still prefer to keep serving them from unpkg so that we avoid their weight on the package and avoid a build step here. Anyway, everything is up for grabs. |
When was this changed? Because things where working for me two weeks ago. |
I'm looking into this. I have recreated the issue. |
From what I gathered, unpkg is not sending the required header to allow cross-origin content loading. There is an issue for that in unpkg repo mjackson/unpkg#290 Here are the possible solutions:
|
For a little more detail about the underlying cause of the behavior:
As to why this started to fail recently, I haven't found the exact culprit, but this article on COEP and COOP suggests that browsers have been actively adjusting the way they handle COEP recently. |
Can we document what config is needed for helmet to work? |
ATM graphiql cannot be used with helmet. This config has worked for me in the past, but I suspect new browser versions broke it:
and with the newest chrome(100)/firefox(99) I started getting:
But it worked a few chrome versions back for sure.
As a workaround I won't use helmet for now, but it certainly isn't ideal.
Not sure how to fix it-maybe as a workaround serve those packages from node_modules?
The text was updated successfully, but these errors were encountered: