Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twilio/SMS should support counter based codes #204

Open
nefrob opened this issue Jan 20, 2023 · 0 comments · May be fixed by #206
Open

Twilio/SMS should support counter based codes #204

nefrob opened this issue Jan 20, 2023 · 0 comments · May be fixed by #206

Comments

@nefrob
Copy link

nefrob commented Jan 20, 2023

SMS based codes should be unique each time they are generated by using a counter as part of the code generation. Each time a code is generated the counter increases. This means each code will be different. A validity period would generally not longer be applicable here (leave that up to the app user). Only the most recent code will validate true.

I think this is standard when it comes to SMS 2FA codes. If trench already supports this please link me to the documentation, otherwise this would be a great feature to add either as a default or configurable setting (with the counter being null and unused on the MFA method model if the setting is toggled off).

Ref: https://pyauth.github.io/pyotp/#counter-based-otps.

@nefrob nefrob linked a pull request Feb 1, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant