Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop use of SETLENGTH #82

Open
merliseclyde opened this issue Sep 14, 2024 · 2 comments
Open

drop use of SETLENGTH #82

merliseclyde opened this issue Sep 14, 2024 · 2 comments
Assignees
@merliseclyde
Labels
CRAN Note Notes on cran-checks to address work in progress

Comments

@merliseclyde
Copy link
Owner

As SETLENGTH is not part of the public API, all calls of SETLENGTH need to be replaced in advance of strict enforcement
merliseclyde added a commit that referenced this issue Sep 15, 2024
@merliseclyde
avoid calls to SETLENGTH in lm_sampleworep.c and glm_sampleworep.c Is…
312acfc 
…sue #82 as non-API function
merliseclyde added a commit that referenced this issue Sep 15, 2024
@merliseclyde
update news for ISSUE #82
a09a9cc
merliseclyde added a commit that referenced this issue Sep 15, 2024
@merliseclyde
updated glm_mcmc.c and lm_mcmc.c to avoid use of SETLENGTH (issue #82)
7996476
merliseclyde added a commit that referenced this issue Sep 16, 2024
@merliseclyde
replaced SETLENGTH in remaining src files (Issue #82)
a34ef75
@merliseclyde
Copy link
Owner Author

removed all occurrences of SETLENGTH and updated code appropriately to truncate over-allocated vectors per r-lib/fs#450

@merliseclyde merliseclyde reopened this Sep 17, 2024
@merliseclyde
Copy link
Owner Author

Reopening due to imbalance problems flagged when running tests outside of R CMD check. Code has reverted back to using SETLENGTH to avoid the stack imbalance

merliseclyde added a commit that referenced this issue Nov 19, 2024
@merliseclyde
add counting hereditary constraints for BAS
f230f24 
related to fixing use of SETLENGTH in lm_sampleworep.c and Issue #82
Check Code coverage to see if changes
now bypass SETLENGTH (covered previously in tests)
@merliseclyde merliseclyde self-assigned this Nov 19, 2024
@merliseclyde merliseclyde added CRAN Note Notes on cran-checks to address work in progress labels Nov 19, 2024
merliseclyde added a commit that referenced this issue Nov 26, 2024
@merliseclyde
comment out warning to avoid problems on CRAN until issue with SETLEN…
34a98b4 
…GTH (Issue #82 and Issue #88 resolved)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merliseclyde merliseclyde

Labels
CRAN Note Notes on cran-checks to address work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@merliseclyde