Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_lh_list makes Mat_l vector shorter than LF #8

Open
brianstock opened this issue Jan 6, 2020 · 0 comments
Open

create_lh_list makes Mat_l vector shorter than LF #8

brianstock opened this issue Jan 6, 2020 · 0 comments

Comments

@brianstock
Copy link

brianstock commented Jan 6, 2020

Hi Merrill,

This is just a heads up, since I forked LIME awhile ago to make some changes specific to my application and haven't merged updates in the last year or so... Maybe you've fixed this. But if you haven't come across this potential error yet:

It's possible for create_lh_list to make a Mat_l vector that's shorter than the user-specified length-frequency data dimension. It uses 1.3*linf as the max length, and there's no check for what the user's max length in the LF data is. I stumbled across it when I kept everything (data, model, code) the same except with a lower linf and higher vbk... was surprised it wouldn't run.

Not urgent - I just changed my local create_lh_list to use 1.4*linf for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant