Skip to content

Commit

Permalink
#55: Add exercise rubric
Browse files Browse the repository at this point in the history
  • Loading branch information
ddundo committed Sep 16, 2024
1 parent 8af5e03 commit 414a6a9
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions demos/bubble_shear.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,7 @@ def run_simulation(mesh, t_start, t_end, c0):
# diffusion. Numerical diffusion is necessary for numerical stability and for preventing
# oscillations, but it also makes the solution irreversible. The amount of difussion
# added is related to the grid Péclet number :math:`Pe = U\,h/2D`: the coarser the mesh
# is, the more diffusion is added. We encourage the reader to verify this by running the
# simulation on a sequence of finer uniform meshes.
# is, the more diffusion is added.
#
# In order to quantify the above observation, we will compute the relative :math:`L^2`
# error between the initial condition and the final concentration field on the final
Expand Down Expand Up @@ -474,9 +473,12 @@ def adapt_metric_advection(mesh, t_start, t_end, c):
# :align: center
#
# In conclusion, the choice of mesh adaptation algorithm depends on the specific problem
# at hand, as well as the computational resources available. We encourage the reader to
# experiment with different metric parameters, different adaptation frequencies, and
# even different velocity fields to further explore the capabilities and limitations of
# the above-presented mesh adaptation algorithms.
# at hand, as well as the computational resources available.
#
# .. rubric:: Exercise
#
# We encourage the reader to experiment with different metric parameters, different

This comment has been minimized.

Copy link
@jwallwork23

jwallwork23 Sep 17, 2024

Member

Perhaps I was misleading when I said "formal exercise". I just meant putting it in its own section. I'd drop the "we encourage the reader to".

# adaptation frequencies, and even different velocity fields to further explore the
# capabilities and limitations of the above-presented mesh adaptation algorithms.
#
# This demo can also be accessed as a `Python script <bubble_shear.py>`__.

0 comments on commit 414a6a9

Please sign in to comment.