Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric advection demo #144

Closed
ddundo opened this issue Jul 26, 2024 · 6 comments · Fixed by #145
Closed

Metric advection demo #144

ddundo opened this issue Jul 26, 2024 · 6 comments · Fixed by #145
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ddundo
Copy link
Member

ddundo commented Jul 26, 2024

I've done the bubble shear test case with metric advection - would it be useful to put it up as a demo? I don't know how niche this is :)

@jwallwork23
Copy link
Member

Sure, go for it!

@jwallwork23 jwallwork23 added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 26, 2024
@ddundo
Copy link
Member Author

ddundo commented Aug 5, 2024

@jwallwork23 could you please tell me how you computed the "relative L2 error" in the bubble shear section in your thesis? I'm thinking what would be the best way to interpolate the fields such that they're on the same mesh - i.e. interpolate the final solution or the initial one onto the other one's mesh, or onto a fine resolution uniform mesh?

I'm also curious how you computed the relative error considering there are 0 values of the concentration field. I don't know if there's a more elegant way to do it than just manually handling those :)

@jwallwork23
Copy link
Member

https://github.com/jwallwork23/adapt_utils/blob/master/unsteady/test_cases/bubble_shear/run_adapt.py

Here’s the code. It appears I redefined the initial condition on the final mesh. I think the relative error is meant as a quotient of spatial integrals, rather than pointwise? (I don’t have the thesis open- am on the train.)

@ddundo
Copy link
Member Author

ddundo commented Aug 5, 2024

Ah sorry, I should have thought myself to look at the code :) thanks for this!

@karimnorouzi
Copy link

karimnorouzi commented Sep 12, 2024 via email

@ddundo
Copy link
Member Author

ddundo commented Sep 12, 2024

Hi @karimnorouzi, the PR is under review at the moment (#145) so you can look there. It will likely get merged within the next week

@ddundo ddundo moved this from In Progress to In review in Mesh Adaptation development board Sep 12, 2024
ddundo added a commit that referenced this issue Sep 15, 2024
@ddundo ddundo closed this as completed in d52f046 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants