Misleading time in demos

[ddundo]

All demos have their get_solver defined as something like this:

def get_solver(mesh_seq):
    def solver(index, ic):
        ...
        # Time integrate from t_start to t_end
        P = mesh_seq.time_partition
        t_start, t_end = P.subintervals[index]
        dt = P.timesteps[index]
        t = t_start
        while t < t_end - 1.0e-05:
            solve(F == 0, u, ad_block_tag="u")
            u_.assign(u)
            t += dt
        return {"u": u}

    return solver

where the implication is that we are solving the problem for $t \in [t_{start}, t_{end})$ when it's actually $t \in (t_{start}, t_{end}]$. This doesn't matter in these demos, but it does in my bubble shear demos, where I had to change this to

t = t_start + dt
while t < t_end + 0.5 * dt:
    # update the background velocity field at the current timestep
    u.interpolate(velocity_expression(x, y, t))

in order to compute the velocity at the correct time.

How about refactoring the demos to instead look like this:

def get_solver(mesh_seq):
    def solver(index, ic):
        ...
        # Time integrate from t_start to t_end
        P = mesh_seq.time_partition
        num_timesteps = P.num_timesteps_per_subinterval[index]
        for _ in range(num_timesteps):
            solve(F == 0, u, ad_block_tag="u")
            u_.assign(u)
        return {"u": u}

    return solver

[jwallwork23]

Sure, that works! Cheers

[ddundo]

@jwallwork23 actually I guess a better solution would be to more rigorously define tp.subintervals so they follow this $t \in (t_{start}, t_{end}]$. At the moment we have tp.subintervals be something like [(0, 1), (1, 2)] whereas we would need [(0+dt, 1), (1+dt, 2)]. What do you think?

Then we can keep t = t_start in demos and similarly MeshSeq.time (introduced in #137) can be initialised to the subinterval start time. So it would be nice to keep everything consistent.

[jwallwork23]

I think rather than edit the subintervals attribute (which makes intuitive sense given how the TimePartition splits up the temporal domain), it would be better to introduce two new ones (something like):

• timestep_starts - a list containing the time at the start of each timestep
• timestep_ends - a list containing the time at the end of each timestep

Then you could even

for time in tp.timestep_ends:
    # solve

[ddundo]

Thanks @jwallwork23. I'm waiting to see how the use of time develops in #28 before addressing this. (no rush at all)

Initial thought is that I don't really see a need to introduce timestep_starts and timestep_ends - I think I would rather just make a clear (verbal) distinction between tp.subintervals[0][0] and MeshSeq.time, for both of which we currently use "start time"

[ddundo]

Thanks @jwallwork23. I'm waiting to see how the use of time develops in #28 before addressing this. (no rush at all)

We decided not to introduce MeshSeq.time so only the time in demos themselves should be modified.