Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail #222

Closed
ddundo opened this issue Oct 14, 2024 · 1 comment · Fixed by #225
Closed

Tests fail #222

ddundo opened this issue Oct 14, 2024 · 1 comment · Fixed by #225
Labels
bug Something isn't working PRIORITY We should address this ASAP

Comments

@ddundo
Copy link
Member

ddundo commented Oct 14, 2024 •
edited
Loading

See https://github.com/mesh-adaptation/goalie/actions/runs/11310614359. Tests fail on the new docker image
@ddundo ddundo added bug Something isn't working PRIORITY We should address this ASAP labels Oct 14, 2024
ddundo added a commit that referenced this issue Oct 14, 2024
@ddundo
#222: Fix cache error in tests
ac2908e
@ddundo ddundo mentioned this issue Oct 14, 2024
Merged
ddundo added a commit that referenced this issue Oct 14, 2024
@ddundo
#222: Fix TSFC cache clear
30b7c2b
@ddundo
Copy link
Member Author

ddundo commented Oct 14, 2024 •
edited
Loading

The issue is in conftest.py files:

from firedrake.tsfc_interface import TSFCKernel
from pyop2.global_kernel import GlobalKernel

TSFCKernel._cache.clear()
GlobalKernel._cache.clear()

Neither of these no longer have the _cache attribute. The TSFC one was easy to fix:

from firedrake.tsfc_interface import clear_cache
clear_cache()

but I couldn't find the updated way for pyop2

Edit:
I think that pyop2 is now

from pyop2.caching import clear_memory_cache
from pyop2.mpi import COMM_WORLD

clear_memory_cache(COMM_WORLD)

ddundo added a commit that referenced this issue Oct 14, 2024
@ddundo
#222: Fix pyop2 cache clear
73e38f4
ddundo added a commit that referenced this issue Oct 14, 2024
@ddundo
#222: Fix pyop2 cache clear 2
1a83733
@ddundo ddundo linked a pull request Oct 14, 2024 that will close this issue
Export function data to vtk or h5 #221
Merged
@jwallwork23 jwallwork23 moved this from Backlog to In review in Mesh Adaptation development board Oct 20, 2024
ddundo added a commit that referenced this issue Oct 24, 2024
@ddundo
#222: Update caching
ee467d4
@ddundo ddundo mentioned this issue Oct 24, 2024
Merged
@ddundo ddundo closed this as completed in fdd3bf5 Oct 24, 2024
acse-ej321 added a commit that referenced this issue Oct 24, 2024
@acse-ej321
Merge branch 'main' of https://github.com/mesh-adaptation/goalie into…
276cb3a 
… 220_clear_fields_after_indicate

merge #222 update caching fix into branch
@ddundo ddundo removed a link to a pull request Oct 31, 2024
Export function data to vtk or h5 #221
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working PRIORITY We should address this ASAP
Projects
Mesh Adaptation development board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#222: Update caching mesh-adaptation/goalie
1 participant
@ddundo