-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export function data to vtk or h5 #221
Conversation
I forgot to tag the issue in commit messages. Sorry!
Edit: fixed in a separate issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @ddundo. A few suggestions, the main thing being adding unit tests that check the export works.
Thanks for reviewing @jwallwork23! I addressed all comments now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one request for documentation.
Thanks again @jwallwork23! I cancelled the CI since it's just a docstring update. |
Minor addition to #221. I just saw that `CheckpointFile.save_function` can be provided an `idx` for timestepping.
Partially addresses #117.
This PR adds the
export
method toFunctionData
so that solutions and indicators may be easily exported to vtu or hdf5 files.