Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export function data to vtk or h5 #221

Merged
merged 25 commits into from
Nov 1, 2024
Merged

Export function data to vtk or h5 #221

merged 25 commits into from
Nov 1, 2024

Conversation

ddundo
Copy link
Member

@ddundo ddundo commented Oct 14, 2024

Partially addresses #117.

This PR adds the export method to FunctionData so that solutions and indicators may be easily exported to vtu or hdf5 files.

@ddundo ddundo added the enhancement New feature or request label Oct 14, 2024
@ddundo ddundo self-assigned this Oct 14, 2024
@ddundo
Copy link
Member Author

ddundo commented Oct 14, 2024

I forgot to tag the issue in commit messages. Sorry!

I also added a partial fix for #222 (see #222 (comment)). @jwallwork23 could you fix the pyop2 cache problem if you're more familiar with it? :)

Edit: I think I fixed it properly now, could you please check? Sorry for doing it in the same PR, but it's just 4 lines :)

Edit: fixed in a separate issue

@ddundo ddundo requested a review from jwallwork23 October 14, 2024 18:32
@ddundo ddundo linked an issue Oct 14, 2024 that may be closed by this pull request
Copy link
Member

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @ddundo. A few suggestions, the main thing being adding unit tests that check the export works.

demos/gray_scott.py Outdated Show resolved Hide resolved
demos/gray_scott_split.py Outdated Show resolved Hide resolved
goalie/function_data.py Outdated Show resolved Hide resolved
goalie/function_data.py Outdated Show resolved Hide resolved
goalie/function_data.py Outdated Show resolved Hide resolved
test/test_function_data.py Outdated Show resolved Hide resolved
@ddundo ddundo removed a link to an issue Oct 31, 2024
@ddundo ddundo requested a review from jwallwork23 October 31, 2024 20:54
@ddundo
Copy link
Member Author

ddundo commented Oct 31, 2024

Thanks for reviewing @jwallwork23! I addressed all comments now :)

Copy link
Member

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one request for documentation.

@ddundo
Copy link
Member Author

ddundo commented Nov 1, 2024

Thanks again @jwallwork23! I cancelled the CI since it's just a docstring update.

@ddundo ddundo requested a review from jwallwork23 November 1, 2024 10:34
@ddundo ddundo merged commit a228fbc into main Nov 1, 2024
1 check failed
@ddundo ddundo deleted the 117_export branch November 1, 2024 13:05
@ddundo ddundo restored the 117_export branch November 1, 2024 21:44
ddundo added a commit that referenced this pull request Nov 2, 2024
Minor addition to #221. I just saw that `CheckpointFile.save_function`
can be provided an `idx` for timestepping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants