Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get value_shape from function spaces #231

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Get value_shape from function spaces #231

merged 1 commit into from
Nov 17, 2024

Conversation

ddundo
Copy link
Member

@ddundo ddundo commented Nov 17, 2024 •
edited
Loading

Closes #230. Related to mesh-adaptation/animate#158

@ddundo ddundo self-assigned this Nov 17, 2024
@ddundo ddundo added bug Something isn't working PRIORITY We should address this ASAP labels Nov 17, 2024
@ddundo
Copy link
Member Author

ddundo commented Nov 17, 2024

Fixed all goalie problems here. Only one related to mesh-adaptation/animate#158 remains

@ddundo ddundo mentioned this pull request Nov 17, 2024
Merged
jwallwork23
jwallwork23 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks for the quick fix.

@jwallwork23
Copy link
Member

The Firedrake Docker env with patched Animate will get updated in the latest Action of mesh-adaptation/docs#59 so will re-run tests once that's done.

@ddundo
Copy link
Member Author

ddundo commented Nov 17, 2024

Thanks Joe!

@ddundo ddundo merged commit cf7161b into main Nov 17, 2024
1 check passed
@ddundo ddundo deleted the 230_value_shape branch November 17, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwallwork23 jwallwork23 jwallwork23 approved these changes

@acse-ej321 acse-ej321 Awaiting requested review from acse-ej321

Assignees

@ddundo ddundo

Labels
bug Something isn't working PRIORITY We should address this ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is failing
2 participants
@ddundo @jwallwork23