Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure tests #237

Merged
merged 9 commits into from
Nov 24, 2024
Merged

Restructure tests #237

merged 9 commits into from
Nov 24, 2024

Conversation

jwallwork23
Copy link
Member

Closes #236.

This PR puts all the tests in the same directory, with a subdirectory for the adjoint ones. Various parts of the conftest are no longer needed.

I also plan to crank up the test coverage on a few modules in this PR.

@jwallwork23 jwallwork23 added the testing Extensions and improvements to the testing infrastructure label Nov 23, 2024
@jwallwork23 jwallwork23 self-assigned this Nov 23, 2024
@jwallwork23 jwallwork23 marked this pull request as ready for review November 24, 2024 11:59
Copy link
Member

@ddundo ddundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You just added a duplicate test which should be removed. I'll approve so you can merge whenever :)

Edit: sorry, ignore the comment! All good

test/adjoint/test_adjoint_mesh_seq.py Show resolved Hide resolved
@jwallwork23 jwallwork23 merged commit 7f61988 into main Nov 24, 2024
1 check passed
@jwallwork23 jwallwork23 deleted the 236_restructure-tests branch November 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Extensions and improvements to the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure tests
3 participants