Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [Feature Request]: Unification of MQTT Settings #5423

Closed
2 of 3 tasks
Xaositek opened this issue Nov 22, 2024 · 4 comments
Closed
2 of 3 tasks

🚀 [Feature Request]: Unification of MQTT Settings #5423

Xaositek opened this issue Nov 22, 2024 · 4 comments
Labels
3.0 Planned for next major release tech debt Code or lib references that are not up to date or propper standards

Comments

@Xaositek
Copy link

OS

iOS, iPadOS, macOS

Description

I'd like to suggest in the Apple programs, we look at unifying the location of similar settings, starting with MQTT. Setting up a new node and verifying configuration across two settings pages and up to 8 channel pages and result in missed elections.

Currently you must visit and verify:

  • Settings > LoRa Config > Ignore MQTT or Ok to MQTT
  • Settings > MQTT - verify base configuration and setup
  • Channels > (Visit each channel) > Uplink and/or Downlink are selected

The ask here is to unify all MQTT related checks, configuration and opt-in/opt-out into a single settings screen.

Participation

  • I am willing to pay to sponsor this feature.
  • I am willing to submit a pull request for this feature.

Additional comments

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Xaositek Xaositek added the enhancement New feature or request label Nov 22, 2024
@garthvh
Copy link
Member

garthvh commented Nov 22, 2024

The settings in the app directly mirror the protobufs that they are a part of, this is required for remote admin functionality a cleanup of these settings needs to start in the protobufs themselves. MQTT config is also at the size limit now.

@Xaositek
Copy link
Author

Can it be a backlog item to revisit at a time when it makes sense?

@garthvh garthvh transferred this issue from meshtastic/Meshtastic-Apple Nov 22, 2024
@garthvh garthvh added tech debt Code or lib references that are not up to date or propper standards 3.0 Planned for next major release and removed enhancement New feature or request labels Nov 22, 2024
@GUVWAF
Copy link
Member

GUVWAF commented Nov 22, 2024

"Ignore MQTT" and "OK to MQTT" were deliberately chosen to be in the LoRa config, because you control it for receiving and transmitting over LoRa. A user should not have to check a specific module configuration to control what's happening over LoRa in my opinion.

@garthvh
Copy link
Member

garthvh commented Nov 23, 2024

Being that there is already a 3.0 issue for uplink and downlink, there is not much left here

@garthvh garthvh closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Planned for next major release tech debt Code or lib references that are not up to date or propper standards
Projects
None yet
Development

No branches or pull requests

3 participants