Feat: Add MultiSelect component #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danditomaso
changed the title
|
Is there somewhere that explains what these mean? |
Hunter275
added
enhancement
That's a good point. There is this on the Meshtastic website (https://meshtastic.org/docs/configuration/radio/position/#position-flags) which does a decent job explaining it. Do you think we should add an info icon or the hyperlink into the description? |
|
@danditomaso a link to that page would work or a dialog in case no Internet |
|
@Hunter275 Still planning on adding a dialog to provide contextual help, but I looked at Android and IOS and found neither app provides further help on what these flags mean, should we raise that to those teams to add in order to have parity between apps? |
danditomaso
requested review from
Hunter275
and removed request for
Hunter275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created reusable MultiSelect checkbox component
Created custom hook to manage position flag state (usePositionFlags)
Internal flag state management with computed activeFlags
Type-safe flag manipulation (toggleFlag, setFlag, setFlags)
Fixes #305