From 6a600f1ae9b2b611067bb8147ec2d747a553620c Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 29 Jul 2024 21:09:50 +0200 Subject: [PATCH] Apply suggestions from code review --- run_project_tests.py | 3 +-- unittests/allplatformstests.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/run_project_tests.py b/run_project_tests.py index 236aad9ab94d..959797831582 100755 --- a/run_project_tests.py +++ b/run_project_tests.py @@ -911,8 +911,7 @@ def load_test_json(t: TestDef, stdout_mandatory: bool, skip_category: bool = Fal exclude = False opt_tuple = [(x[0], x[1]) for x in i] for j in matrix['exclude']: - ex_list = list(j.items()) - if all(x in opt_tuple for x in ex_list): + if all(x in opt_tuple for x in j.items()): exclude = True break diff --git a/unittests/allplatformstests.py b/unittests/allplatformstests.py index ec1558d1c7ed..eec356a2c20b 100644 --- a/unittests/allplatformstests.py +++ b/unittests/allplatformstests.py @@ -568,8 +568,7 @@ def test_install_introspection_multiple_outputs(self): def read_install_logs(self): # Find logged files and directories with Path(self.builddir, 'meson-logs', 'install-log.txt').open(encoding='utf-8') as f: - return [Path(l.strip()) for l in filter(lambda l: not l.startswith('#'), - f.readlines())] + return [Path(l.strip()) for l in f.readlines() if not l.startswith('#')] def test_install_log_content(self): '''