Fix handling of Dependency's include_type in few places #13861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem
force-pushed
the
fix-dep-include-type
branch
from
be55a8f
to
fb6ea7b
Compare
|
Any objections? |
bruchar1
reviewed
Nov 18, 2024
| @@ -304,6 +304,8 @@ def __deepcopy__(self, memo: T.Dict[int, 'InternalDependency']) -> 'InternalDepe | |||
| for k, v in self.__dict__.items(): | |||
| if k in {'libraries', 'whole_libraries'}: | |||
| setattr(result, k, copy.copy(v)) | |||
| elif k == 'include_directories': | |||
| setattr(result, k, copy.copy(self.get_include_dirs())) | |||
There was a problem hiding this comment.
nitpick: you do self.get_include_dirs().copy() below, and copy.copy(self.get_include_dirs()) here.... I think I prefer using the copy() method of list, since it is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13858