Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a language project into the Eclipse LWB is error-prone #92

Open
Gohla opened this issue Nov 9, 2021 · 1 comment
Open

Importing a language project into the Eclipse LWB is error-prone #92

Gohla opened this issue Nov 9, 2021 · 1 comment
Labels
C-Bug Category: bug. Not working as expected

Comments

@Gohla
Copy link
Member

Gohla commented Nov 9, 2021

Summary

Importing a language project into the Eclipse LWB is error-prone

What you did

Import a language project into the Eclipse LWB.

What you expected to happen

Building that language project to succeed.

What actually happened

Building that language project failed due to many duplicate definitions. This is caused by Eclipse copying the entire project to the bin directory after importing it, and this in turn is caused by a missing .classpath file.

Context

  • Spoofax version: 0.16.1
  • Operating system & version: Any

Additional information

It should be possible to import a language project into the Eclipse LWB without requiring a .project and .classpath file to be checked into source control. Although the .project file is OK to check-in, the .classpath file is not as it contains file references on the local filesystem.

I see a couple of ways to solve the problem:

  1. ignore bin directories in all meta-languages.
  2. create a builder that always runs before the Java builder that sets up the classpath.
  3. move the Spoofax 3 classpath into some kind of variable, like the org.eclipse.jdt.launching.JRE_CONTAINER variable, such that the .classpath file can be checked into source control.
  4. create an Eclipse project importer for Spoofax 3 language projects based on spoofaxc.cfg files such that .project and .classpath do not need to be checked into source control at all.

in descending order of speed/hackyness.

@Gohla Gohla added the C-Bug Category: bug. Not working as expected label Nov 9, 2021
@Gohla
Copy link
Member Author

Gohla commented Nov 10, 2021

Currently working around the problem by ignoring the bin directory by c9d5d8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Category: bug. Not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant