Fix/remove gmd series tag #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggiornamento del repo principale per modifiche CSW
Update from metadata-101 to master branch
etj
reviewed
Jul 21, 2022
There was a problem hiding this comment.
Instead of replicating code (and removing some apply-templates instructions, so potentially losing some info from the metadata), I guess that it would be better to add a test for dataset/series before adding the automatically computed issueIdentification (https://github.com/metadata101/iso19139.rndt/pull/33/files#diff-f8c99d140c17ea427978f68d8fa7b705ebc4a7ecb877a9014c7744cc22fe35e3R324-R335)
|
Thank you for your answer, we're going to check our code for a better solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating or updating a service metadata a gmd:series tag was created by mistake: in update-fixed-info we fixed this issue separating behaviour for dataset and service metadata