Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Snapshot's daoURI with the attestation framework #205

Closed
Tracked by #239
Rashmi-278 opened this issue Feb 14, 2024 · 7 comments
Closed
Tracked by #239

Integrate Snapshot's daoURI with the attestation framework #205

Rashmi-278 opened this issue Feb 14, 2024 · 7 comments
Assignees
Labels
priority: high High priority

Comments

@Rashmi-278
Copy link
Member

Display the DAO URI of snapshot spaces, published by snapshot https://hub.snapshot.org/api/eip4824/<space_name>
on our frontend with disclaimer that the data provided is by Snapshot and NOT by DAO themselves

@crazyyuan
Copy link
Collaborator

It seems that the 'membersURI' from the Snapshot eip4824 API just contains space members, which are not voters.
This is not what we want.

@thelastjosh thelastjosh added the priority: high High priority label Feb 21, 2024
@thelastjosh thelastjosh changed the title Snapshot EIP-4824 DAO URI Integration Integrate Snapshot's daoURI with the attestation framework Feb 21, 2024
@thelastjosh
Copy link
Member

thelastjosh commented Feb 21, 2024

What we need to do here next is clearly describe what it means to publish daoURI data through an attestation, i.e. since Snapshot will be publishing daoURI data about DAOs through an attestation. This issue is already being addressed in part through #99 and #100 for Optimism, i.e. because the Optimism Foundation needs to publish daoURI data about the Optimism Collective through an attestation.

@Rashmi-278
Copy link
Member Author

Created a PR on Snapshot to include voters in their membersURI
snapshot-labs/snapshot-hub#812

Conveyed this to their team, waiting for their review and response on this

@Rashmi-278 Rashmi-278 self-assigned this Mar 6, 2024
@Rashmi-278
Copy link
Member Author

Rashmi-278 commented Mar 6, 2024

Fabien's review,

In some space there can be millions of voters, I think we need to put a limit on the query otherwise it will take too long to resolve or load for an integrator

Based on this, I've added limit, pagination, and uniqueness checks for members.
I've pushed my changes fo further review.

@Rashmi-278
Copy link
Member Author

Pushed changes, snapshot-labs/snapshot-hub#812

@thelastjosh
Copy link
Member

Just taking a long time, ball is still in their court to review Rashmi's PR.

@thelastjosh
Copy link
Member

This was combined with #239 , will close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority
Projects
None yet
Development

No branches or pull requests

3 participants