Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-1723; Clean up bioscfg before deploying #9

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

jakeschuurmans
Copy link
Collaborator

What does this PR do

  • Fix linting config
  • Remove test vars from chart
  • Add file handler closing
  • Renaming ENV var, no need to have a prefix that is the app name

- Fix linting
- Remove test vars from chart
- Add file handler closing
- Renaming ENV var, no need to have a prefix that is the app name
Copy link
Contributor

@ofaurax ofaurax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look to the comment, not sure it's intentional

@@ -69,6 +69,7 @@ func readInFile(v *viper.Viper, cfg *Configuration, path string) error {
if err != nil {
return errors.Wrap(ErrConfig, err.Error())
}
defer fh.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this has its place in a "cleanup".
At least put it in a different commit

@jakeschuurmans jakeschuurmans merged commit 25930ed into main Oct 15, 2024
6 checks passed
@jakeschuurmans jakeschuurmans deleted the FS-1729 branch October 15, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants