Prevent unintended stdout print (#2943)

* Ops * null it is
metalbear-co · Dec 2, 2024 · 3f0df1b · 3f0df1b
1 parent e24147c
commit 3f0df1b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog.d/+no-stdout-sidecar-start.internal.md b/changelog.d/+no-stdout-sidecar-start.internal.md
@@ -0,0 +1 @@
+use `Stdio::piped()` for "sidecar start" patch added in [#2933](https://github.com/metalbear-co/mirrord/pull/2933).
diff --git a/mirrord/cli/src/container.rs b/mirrord/cli/src/container.rs
@@ -221,7 +221,11 @@ async fn create_sidecar_intproxy(
         {
             let mut container_start_command = Command::new(&runtime_binary);
 
-            container_start_command.args(["start", &sidecar_container_id]);
+            container_start_command
+                .args(["start", &sidecar_container_id])
+                .stdin(Stdio::null())
+                .stdout(Stdio::null())
+                .stderr(Stdio::null());
 
             let _ = container_start_command.status().await.map_err(|err| {
                 ContainerError::UnsuccesfulCommandOutput(
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		use `Stdio::piped()` for "sidecar start" patch added in [#2933](https://github.com/metalbear-co/mirrord/pull/2933).