Controller: don't put the error in the status #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error is lenghty and doesn't fit the status, resulting in errors reconciling the MetalLB resource. Here we just log the error and add "internal error". Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
force-pushed
the
noerrorinstatus
branch
5 times, most recently
from
64f97ca
to
44614c7
Compare
Signed-off-by: Federico Paolinelli <[email protected]>
Bumping controller-gen to make it compatible with the new go version and regenerate the manifests. Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
force-pushed
the
noerrorinstatus
branch
from
44614c7
to
e7a8758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is lenghty and doesn't fit the status, resulting in errors reconciling the MetalLB resource.
Here we just log the error and add "internal error".