Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single base tag in metanorma: https://github.com/metanorma/metanorma/… #87

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

opoudjis
Copy link
Contributor

@opoudjis opoudjis commented Feb 3, 2025

…issues/440

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Feb 3, 2025
#
#def xml_namespace
#configuration.document_namespace || XML_NAMESPACE
#end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after #.

#end
#
#def xml_namespace
#configuration.document_namespace || XML_NAMESPACE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation detected (column 8 instead of 6).
Missing space after #.

#configuration.xml_root_tag || XML_ROOT_TAG
#end
#
#def xml_namespace
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation detected (column 6 instead of 8).
Missing space after #.

#def xml_root_tag
#configuration.xml_root_tag || XML_ROOT_TAG
#end
#
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation detected (column 0 instead of 6).

end
#def xml_root_tag
#configuration.xml_root_tag || XML_ROOT_TAG
#end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation detected (column 6 instead of 0).
Missing space after #.

configuration.document_namespace || XML_NAMESPACE
end
#def xml_root_tag
#configuration.xml_root_tag || XML_ROOT_TAG
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation detected (column 8 instead of 6).
Missing space after #.

def xml_namespace
configuration.document_namespace || XML_NAMESPACE
end
#def xml_root_tag
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect indentation detected (column 6 instead of 8).
Missing space after #.

@@ -27,7 +27,7 @@
Metanorma::Generic.configure do |cn|
cn.organization_name_short = Metanorma::Generic::ORGANIZATION_NAME_SHORT
cn.organization_name_long = Metanorma::Generic::ORGANIZATION_NAME_LONG
cn.document_namespace = Metanorma::Generic::DOCUMENT_NAMESPACE
#cn.document_namespace = Metanorma::Generic::DOCUMENT_NAMESPACE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after #.

@opoudjis opoudjis merged commit d9f67f2 into main Feb 16, 2025
7 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant