-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notice: Firelight compatibility with upcoming release post-delivery #360
Comments
The tag change is already supported, and it should support most of the other changes except a couple. |
@ronaldtse according to Reese, the deliverable is static (though we also deliver the build process, it’s not the main part), and build regressions after delivery are normal while we don’t have a stable/unstable release channels and don’t have dependency versions pinned. |
There are 2 things we have to do because the upcoming Monday Metanorma release will be incompatible with the current Firelight.
The docker image for 1.11.5 is:
mn-samples-plateau/.github/workflows/docker.yml Lines 71 to 97 in ad00275
|
hello @ronaldtse thank you for this additional information, however i have a question about the mn version. why is the version 1.11.5 and not 0.2.1? the current metanorma-plateau version is 0.2.1 my understanding on 0.2.1 is that release incorporated a number of small but very important fixes from late january to mid-february (listed here: metanorma/metanorma-plateau#158 ). i have confirmed from multiple checks of github output if we use the 1.11.5 version these fixes are not present. the client and i are using i dont recall a docker release built for metanorma 2.1.2. is there a reason this was not produced? it may be the speed issue? @strogonoff has worked very hard to finish all of the feedback issues by Feb 28th, as requested by the client. this date was the final for addressing issues but the final delivery of the project is described here. from March 1 to March 7 the client will be addressing feedback from M2 and finalizing the content of the documents. therefore the week of March 3 the static artifacts of the viewer builds matching the document content the client has updated are needed. i have a meeting with the client on Feb 28th. i will supply more information thereafter. happy to discuss options/work arounds. thank you. |
1.11.5 refers to the docker version, which uses the same version as the "metanorma-cli" gem. The versioning number is separate from the "metanorma" or the "metanorma-plateau" gem. You can consider it the "package version. |
Yes, it would be a good idea to pin versions. New root tag is not a problem, I updated to support it, but new xrefs and other structural changes will need some time to support. |
hello @ronaldtse thank you for this information.
i am sorry i still dont quite understand. these are the metanorma related versions we are using at this time during our local builds:
in the discussion above will this "locked" version support these releases (like: metanorma 2.1.2, metanorma-cli 1.12.0, and metanorma-plateau 0.2.1)? in my understanding the fixes listed here: metanorma/metanorma-plateau#158 are mostly in lutaml, metanorma-plateau, and mn-requirements. i tried to explain some issues about the new release to the client today. they are concerned that updates and fixes mentioned above may not be stable on github and that the github mn build may not be synchronized with the github firelight build. the client asked for instructions how to setup firelight tool chain locally so they can use the above releases to generate the firelight "packages" |
Firelight is mostly processing new XML fine. One confusion is with links, it’s unclear what’s the deal with |
One thing I’d like to get a hold of is latest MN XML for both documents, since it won’t be available in GHA if we pin it to stable version. I’ll try running Ruby toolchain and see if it works… |
https://github.com/metanorma/metanorma-model-iso/blob/main/grammars/isodoc-presentation.rnc
A ticket you were notified of:
|
@strogonoff It is very important that you review ALL Presentation XML tickets in the sprint that you have missed: they each have a PDF counterpart ticket, which summarised the changes made. The fact that your compilation does not break is neither here nor there: all these containers have changed to use fmt-* counterpart elements, containing the text to be rendered, and they all mean that the sibling or parent Semantic XML node is to be ignored in rendering. https://github.com/metanorma/isodoc/releases/tag/v3.0.0 Presentation XML refactor, identifier: metanorma/mn-requirements#35 |
I was able to compile the docs and continuing to update Firelight Metanorma integration to new schema version. @opoudjis Appreciated link to refs grammar. Regarding pings, feel free to not ping me in gem tickets unless it’s a ticket I am participating in. As schema consumer I think it’s probably enough to have one ping with rundown of all breaking changes / new features per version update, like in your latest comment[0]. Or just making it part of changelog would sort it, I suppose. Will circle back to it later. [0] Though in a more digestible form—Metanorma gem tickets are your work process and normally much of it is not understandable/relevant for outsiders or just people not directly working on the gems. It could be useful when troubleshooting, but is too much if it’s just routine upgrade… |
Compatibility with new schema is worked on in https://github.com/metanorma/firelight/tree/metanorma-schema-v2.0.0. |
This is an advance notice to the team that the upcoming release on Monday will be incompatible with the current version of Firelight.
As we are preparing for delivery on 2025-02-28, we have frozen the current XML file to the current version, which has the XML root of ("old version"):
On 2025-03-03 (Monday), the new root tag will be ("new version"):
<metanorma ... >
Firelight will process the "old version" until it is updated for the "new version" (after 2025-02-28).
FYI @ReesePlews @strogonoff
The text was updated successfully, but these errors were encountered: