Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when several routes match current path #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue when several routes match current path #39

wants to merge 1 commit into from

Commits on Jun 1, 2016

  1. Fix issue when several routes match current path 

    Currently, doing:

```javascript
Picker.route('somePath', (params, req, res, next) => {
  if (req.method == 'POST') {
     ...
  } else { next(); }
});
Picker.route('somePath', (params, req, res, next) => {
  if (req.method == 'GET') {
     ...
  } else { next(); }
});
```

will not reach the GET route if the request is `GET somePath`. If you accept the PR, it's be good to update picker's version and the dependency in flow-router-ssr at https://github.com/kadirahq/flow-router/blob/ssr/package.js#L61
    @gsabran
    gsabran committed Jun 1, 2016
    Configuration menu
    Copy the full SHA
    daddd49 View commit details
    Browse the repository at this point in the history