Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert project to TypeScript and use svelte-kit package to package library #12

Open
metonym opened this issue Jun 19, 2022 · 4 comments

Comments

@metonym
Copy link
Owner

metonym commented Jun 19, 2022

With unit tests in place, we can more confidently refactor the code to TypeScript. In addition to greater type safety, this would conserve the manual effort of syncing type definitions.

SvelteKit package is probably the best option to do this.

@MatousAc
Copy link

I would also love to see this available in SvelteKit. Thanks!

@metonym
Copy link
Owner Author

metonym commented Dec 27, 2022

@MatousAc Does this library not work for you in SvelteKit?

@MatousAc
Copy link

Hmm, I'm honestly kinda new to Svelte. But I guess maybe the problem wasn't that I was using sveltekit, but that I was trying your example in TypeScript rather than JavaScript.
I'll try that out now that I have reconsidered the problem.

@MatousAc
Copy link

I'm pretty sure that the problem is that I am using a custom-typed (TS) svelte store for my theme variable. That just doesn't seem to be compatible with this library. Kinda makes sense. At this point, I'm doing most of it myself anyways, so I might as well detect the user's OS preferences too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants