You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am evaluating this lib for usage in constructing responses from my CLJS lambda functions but I have noticed that the main file is a http_response.clj is .clj file.
Is this something you folks would be willing to change? I could try to work on something that works on both ClojureScript and self-host for instance.
It would basically importing things from macchiato or copy over the bits it needs from ring instead of referring the vars.
What do you think?
The text was updated successfully, but these errors were encountered:
I think it's a great idea to have common/cljc abstractions for simple things like http responses. There are at least two friendly copies out there, macchiato being one.
The ring.util.http-response is intended to be a drop-in-replacement for ring.util.response, so all the extra functions should be there. Copying those instead of referring to vars is a good idea, and would give two dependencies less. PR most welcome.
I am evaluating this lib for usage in constructing responses from my CLJS lambda functions but I have noticed that the main file is a
http_response.clj
is.clj
file.Is this something you folks would be willing to change? I could try to work on something that works on both ClojureScript and self-host for instance.
It would basically importing things from
macchiato
or copy over the bits it needs fromring
instead of referring the vars.What do you think?
The text was updated successfully, but these errors were encountered: