Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zscore ci level #70

Open
graceannobrien opened this issue Oct 21, 2024 · 0 comments
Open

zscore ci level #70

graceannobrien opened this issue Oct 21, 2024 · 0 comments

Comments

@graceannobrien
Copy link
Collaborator

graceannobrien commented Oct 21, 2024

Logic for .ci and .zscore arguments is confusing: User can only input 90 or 95% CI, else user has to provide z-score AND CI. A user could input mismatching .ci and .zscore (i.e. ci 80 and z-score 1.96) and function would allow that

define_param_table(.estimates = paramEstimatePath, .key = paramKeyPath, .ci = 95) 
define_param_table(.estimates = paramEstimatePath, .key = paramKeyPath, .ci = 90) 
define_param_table(.estimates = paramEstimatePath, .key = paramKeyPath, .ci = 80, .zscore = 1.282)

Proposal:

  • allow user to input .ci OR .zscore and function will calculate the other one. Seems likely most users will use .ci.
  • if user provides both, function will check that they match

Concerns:

  • Can we always assume users will want to use two-tailed z-score?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant