Fix MA0075 for binary operations (#645)

meziantou · Nov 8, 2023 · 6c2faf3 · 6c2faf3
1 parent ad76c97
commit 6c2faf3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/Meziantou.Analyzer/Internals/CultureSensitiveFormattingContext.cs b/src/Meziantou.Analyzer/Internals/CultureSensitiveFormattingContext.cs
@@ -209,6 +209,9 @@ public bool IsCultureSensitiveOperation(IOperation operation, CultureSensitiveOp
 
         if (operation is IArrayElementReferenceOperation arrayElementReference)
             return IsCultureSensitiveType(arrayElementReference.Type, format: null, instance: null, options);
+
+        if (operation is IBinaryOperation binaryOperation)
+            return IsCultureSensitiveType(binaryOperation.Type, format: null, instance: null, options);
 
         // Unknown operation
         return true;

diff --git a/tests/Meziantou.Analyzer.Test/Rules/DoNotUseImplicitCultureSensitiveToStringAnalyzerTests.cs b/tests/Meziantou.Analyzer.Test/Rules/DoNotUseImplicitCultureSensitiveToStringAnalyzerTests.cs
@@ -333,6 +333,24 @@ void A()
         _ = "abc" + char.ToLower(c, System.Globalization.CultureInfo.InvariantCulture);
     }
 }
+""";
+        await CreateProjectBuilder()
+              .WithSourceCode(sourceCode)
+              .ValidateAsync();
+    }
+
+    [Fact]
+    public async Task ConcatNoDiagnostic_Boolean()
+    {
+        var sourceCode = """
+class Test
+{
+    void A()
+    {
+        bool? value = null;
+        _ = "=" + (value == true);
+    }
+}
 """;
         await CreateProjectBuilder()
               .WithSourceCode(sourceCode)