diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6ed9f54..aebc739 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,6 +13,8 @@ jobs: env: CXXFLAGS: -Wall -Wextra -Wno-deprecated-declarations -Werror -Wno-stringop-overflow steps: + - name: Setup system name + run: echo "SYSTEM_NAME=$(lsb_release --codename --short)" >> $GITHUB_ENV - uses: actions/checkout@v4 with: submodules: true @@ -33,7 +35,7 @@ jobs: -D MC_COMMIT_SHA=${{github.sha}} -D MC_BUILD_NUMBER=${{github.run_number}} -D CPACK_GENERATOR=DEB - -D CPACK_SYSTEM_NAME=$(lsb_release --codename --short) + -D CPACK_SYSTEM_NAME=$SYSTEM_NAME - name: Build run: cmake --build ${{github.workspace}}/build --target midiconn -j $(nproc) - name: Create DEB package @@ -41,7 +43,7 @@ jobs: - name: Upload Artifacts uses: actions/upload-artifact@v4 with: - name: linux + name: linux-${{env.SYSTEM_NAME}} path: | ${{github.workspace}}/build/midiconn ${{github.workspace}}/build/*.deb diff --git a/src/UpdateChecker.cpp b/src/UpdateChecker.cpp index 2df7f35..81cd745 100644 --- a/src/UpdateChecker.cpp +++ b/src/UpdateChecker.cpp @@ -19,7 +19,6 @@ UpdateChecker::UpdateChecker() void UpdateChecker::trigger_check() { - m_update_check_finished = false; m_latest_version_written = false; std::thread([this] { using namespace std::chrono_literals; diff --git a/src/UpdateChecker.hpp b/src/UpdateChecker.hpp index 3555ca4..33d95a5 100644 --- a/src/UpdateChecker.hpp +++ b/src/UpdateChecker.hpp @@ -34,7 +34,6 @@ struct UpdateChecker CheckResult get_latest_version() const; private: - [[maybe_unused]] bool m_update_check_finished = false; CheckResult m_latest_version_result = {}; std::atomic_bool m_latest_version_written; };