New and Unmanaged runs header (distributed-system-analysis#3548)

PBENCH-1265
mfleader · Sep 6, 2023 · bf9f936 · bf9f936
1 parent c02e7de
commit bf9f936
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/dashboard/src/modules/components/OverviewComponent/NewRunsComponent.jsx b/dashboard/src/modules/components/OverviewComponent/NewRunsComponent.jsx
@@ -20,12 +20,7 @@ import {
   Thead,
   Tr,
 } from "@patternfly/react-table";
-import {
-  MetaDataModal,
-  MetadataRow,
-  NewRunsRow,
-  RenderPagination,
-} from "./common-component";
+import { MetadataRow, NewRunsRow, RenderPagination } from "./common-component";
 import React, { useCallback, useState } from "react";
 import {
   deleteDataset,
@@ -42,13 +37,9 @@ import { uid } from "utils/helper";
 
 const NewRunsComponent = () => {
   const dispatch = useDispatch();
-  const {
-    newRuns,
-    initNewRuns,
-    selectedRuns,
-    isMetadataModalOpen,
-    checkedItems,
-  } = useSelector((state) => state.overview);
+  const { newRuns, initNewRuns, selectedRuns, checkedItems } = useSelector(
+    (state) => state.overview
+  );
 
   const [perPage, setPerPage] = useState(ROWS_PER_PAGE);
   const [page, setPage] = useState(START_PAGE_NUMBER);
@@ -245,7 +236,6 @@ const NewRunsComponent = () => {
           />
         </InnerScrollContainer>
       </OuterScrollContainer>
-      {isMetadataModalOpen && <MetaDataModal />}
     </div>
   );
 };

diff --git a/dashboard/src/modules/components/OverviewComponent/index.jsx b/dashboard/src/modules/components/OverviewComponent/index.jsx
@@ -12,6 +12,7 @@ import {
 } from "@patternfly/react-core";
 import {
   Heading,
+  MetaDataModal,
   NewRunsHeading,
   NoExpiringRuns,
   Separator,
@@ -97,9 +98,9 @@ const OverviewComponent = () => {
                     New and Unmanaged
                   </AccordionToggle>
                   <AccordionContent isHidden={!expanded.has("newRuns")}>
+                    <NewRunsHeading />
                     {newRuns.length > 0 ? (
                       <>
-                        <NewRunsHeading />
                         <NewRunsComponent />
                       </>
                     ) : (
@@ -116,6 +117,7 @@ const OverviewComponent = () => {
             {savedRuns.length > 0 ? <SavedRunsComponent /> : <EmptyTable />}
           </Card>
           <RelayComponent />
+          <MetaDataModal />
         </>
       )}
     </div>